add ability to check percentage of bad values #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rationale being that sometimes it might be OK if some points are outside the threshold for a given window. e.g. test that _all_ points in the lookback window must be outside the threshold, not just one.
|
any thoughts on this? I've found it useful to avoid race conditions when e.g. checking the sum of a metric submitted from multiple hosts. check_tsd might come around when only hosts in breach have submitted the datapoints and thus think it is in alarm |
|
no eh? :) |
|
Merged in 1e07aa2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale being that sometimes it might be OK if some points are outside the
threshold for a given window. e.g. test that all points in the lookback
window must be outside the threshold, not just one.