Only remove config files if uninstalling last copy #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RPM post and postun scripts have weird behaviour when you're upgrading. We should check the first argument to each script, to detect if this is a fresh install, ugprade, or uninstall. See http://www.rpm.org/max-rpm/s1-rpm-inside-scripts.html for an explanation.
|
Looks good, could you sign the contrib agreement please? https://docs.google.com/spreadsheet/embeddedform?formkey=dFNiOFROLXJBbFBmMkQtb1hNMWhUUnc6MQ Thanks! |
|
Already signed it years ago. Has it changed since then?
|
manolama
added a commit
that referenced
this pull request
Apr 4, 2015
Only remove config files if uninstalling last copy
|
I notice that this PR isn't in the 'put' branch. Can you merge it into that? Do you need me to open another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPM post and postun scripts have weird behaviour when you're
upgrading. We should check the first argument to each script, to detect
if this is a fresh install, ugprade, or uninstall. See
http://www.rpm.org/max-rpm/s1-rpm-inside-scripts.html for an
explanation.