#16 annotation timelines #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Annotatino classes
This reverts commit ee682a1.
introduced class TagsPanel to encapsulate the form elements and logic for manipulating tags as a preparation to reuse the panel for the annotations tags manipulation
… as filter for annotations
added query build to AnnotationsForm implemented tag retrieval in TagsPanel
…ic to create graph from separate query parameters getTags() now returns a String[][] with tag keys and values. added query parameter "a" to define tag filters for annotations
annotations are now being stored in the 'tsdb' table together with metric values.
|
Hi Benoit, as discussed last week I have removed the extra table 'tsdb-annotation' to store the annotation values. Could you please have a look and give me your feedback? Best regards, Peter |
…cs': 'timelineannotation'" Check if there are already annotations present in hbase before trying to query them.
annotation timestamps did only use their base_time (from the hbase key) but not the delta (from the hbase qualifier). Plus the timestamps had to be "translated" to the local time zone.
|
Benoit, Any plans to merge this pull request sometime soon ? |
Closed
|
Completed with 3ed5b70. Reworked the annotations as individual objects. Used Peter's graph code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
And this is the second try for the annotation timelines. The solution is still based on a separate table 'tsdb-annotation', since the discussion on the mailing list has not yet taken place.
When I get some input there I am happy to discuss the possibilities to integrate those annotations into the metrics table.