[Bug]: Clicking the land info button in the main toolbar no longer activates the land info tool without using the drop down #10987
Comments
|
Seems to happen in 13.3 too (it's fine in 13.1) |
|
Hmm, it calls SetObjectToPlace, and then ResetObjectToPlace straight after. |
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this issue
Jun 12, 2023
…rking as default. Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this issue
Jun 28, 2023
…rking as default. (OpenTTD#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
LordAro
pushed a commit
that referenced
this issue
Jun 28, 2023
…s default. (#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
mrmbernardi
pushed a commit
to mrmbernardi/OpenTTD
that referenced
this issue
Jul 2, 2023
…rking as default. (OpenTTD#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
shoter
pushed a commit
to shoter/OpenTTD
that referenced
this issue
Jul 16, 2023
…rking as default. (OpenTTD#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version of OpenTTD
master
Expected result
Clicking the land info button in the main toolbar activates the land info tool without using the drop down
Actual result
Clicking the land info button in the main toolbar no longer activates the land info tool without using the drop down
Steps to reproduce
Clicking the land info button in the main toolbar
The text was updated successfully, but these errors were encountered: