Fix #10987: Double-close of dropdown stopped land-info tool working as default. #11000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rking as default. Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
PeterN
added
the
backport requested
TrueBrain
approved these changes
Jun 12, 2023
|
I wonder if there might be some scenario where there's a "window property" of "auto closes on losing focus", rather than it being manually done in the OnFocusLost function. Might be TMWFTLB |
|
As there are only two windows that do it, and it would still need to track whether it is already closing, I don't think it would gain much. |
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Jun 28, 2023
…rking as default. (OpenTTD#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
LordAro
pushed a commit
that referenced
this pull request
Jun 28, 2023
…s default. (#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
LordAro
added
backported
mrmbernardi
pushed a commit
to mrmbernardi/OpenTTD
that referenced
this pull request
Jul 2, 2023
…rking as default. (OpenTTD#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
shoter
pushed a commit
to shoter/OpenTTD
that referenced
this pull request
Jul 16, 2023
…rking as default. (OpenTTD#11000) Clicking and releasing on the query toolbar icon is meant to select the land-info tool. This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action. Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Clicking and releasing on the query toolbar icon is meant to select the land-info tool.
This did not work as during closing a window, OnFocusLost() is called, which then closes the window again. These two calls toggled the land-info tool one and off in the same action.
Description
Resolve by not calling Window::Close in OnFocusLost() if the window is already closing.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.