Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When an aircraft crashes, in very rare cases the news points to the crash occuring near tile 0. #11180

Closed
James103 opened this issue Aug 11, 2023 · 0 comments · Fixed by #11184
Labels
bug Something isn't working

Comments

@James103
Copy link
Contributor

Version of OpenTTD

ba95764 on Windows 10, 64-bit (via Steam)

Expected result

When an aircraft crashes, the resulting news and nearby station rating penalty is always centered around the site where the aircraft actually crashed, i.e. in or near the airport the aircraft crash-landed at.

Actual result

When an aircraft crashes, in very rare cases the crash can cause station ratings to drop not only at the airport the aircraft crash-landed at, but also at stations in and around tile 0. The news is also centered near tile 0 if that happens.

Note that this is a very rare occurrence — the aircraft needs to crash with sub-pixel precision for it to have this effect. Else, station ratings are reduced at nearby stations around the airport as expected.

Steps to reproduce

  1. Install SuperSimpleAI, version 19. The GS used in the attached save does not matter.
  2. Install FIRS 1, version 1.4.4M.
  3. Load and unpause the attached save: NLX Carriage, 2117-08-01.zip
  4. An aircraft will crash near NLX Carriage SRC_135 (2102) around 5 seconds after loading.
  5. The resulting news will show the plane as having crashed into a lorry station named Trunfingbourne Bridge North instead. That station is placed at the very top of the map, as close to tile 0 as possible.
  6. Check the station ratings for that lorry station. Notice they are all poor (around 37%), wheres they were all outstanding (at or near 100%) as maintained by the included NewGRF.

See also JGRennison/OpenTTD-patches#549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants