Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11180: Use TileVirtXY for aircraft crash tile #11184

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented Aug 11, 2023

Motivation / Problem

Per #11180, aircraft crashes sometimes affect tile 0.

Description

Upstream a JGRPP commit that fixes the bug, from JGRennison/OpenTTD-patches#549.

I have tested to confirm it works.

Closes #11180.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@2TallTyler 2TallTyler enabled auto-merge (squash) August 11, 2023 13:34
@2TallTyler 2TallTyler merged commit 8ea01c0 into OpenTTD:master Aug 11, 2023
19 checks passed
@2TallTyler 2TallTyler deleted the aircraft-crash-tile branch August 11, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When an aircraft crashes, in very rare cases the news points to the crash occuring near tile 0.
3 participants