Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CheckShipReverse's returned path restricts ship movement, causing it to get lost #12228

Closed
SamuXarick opened this issue Mar 7, 2024 · 0 comments · Fixed by #12474
Closed

[Bug]: CheckShipReverse's returned path restricts ship movement, causing it to get lost #12228

SamuXarick opened this issue Mar 7, 2024 · 0 comments · Fixed by #12474

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

OpenTTD 20240307-master-g8fb26612c0

Expected result

Ship reverses when leaving Grindington Docks, meaning it's allowed to reach region 2,1 and isn't flagged as lost.

CheckShipReverse should try to mimic the same path results as ChooseShipTrack to maintain behaviour consistency.

Actual result

Ship doesn't reverse when leaving Grindington Docks, moves forward and gets cornered between the two docks, flagging the ship as lost.

CheckShipReverse restricts the path to regions 2,2 and 1,2, but the ship happens to be at the top corner of region 2,2, meaning it fails to find a path, defaults to returning false to reversing.

Steps to reproduce

ship checking reverse when leaving dock.zip

  1. Load the attached savegame
  2. Watch ship when it departs from Grindington Docks.
@SamuXarick SamuXarick changed the title [Bug]: Issues with CheckShipReverse [Bug]: CheckShipReverse's returned path restricts ship movement, causing it to get lost Mar 8, 2024
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 8, 2024
@SamuXarick
Fix OpenTTD#12228: Don't restrict path when checking ship reverse on …
101559f 
…first attempt

Try to mimic the same path results as ChooseShipTrack to maintain behaviour consistency.
@SamuXarick SamuXarick mentioned this issue Mar 8, 2024
Closed
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 11, 2024
@SamuXarick
Fix OpenTTD#12228: Don't restrict path when checking ship reverse on …
3ad6d24 
…first attempt

Try to mimic the same path results as ChooseShipTrack to maintain behaviour consistency.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 15, 2024
@SamuXarick
Fix OpenTTD#12228: Don't restrict path when checking ship reverse on …
bb49c32 
…first attempt

Try to mimic the same path results as ChooseShipTrack to maintain behaviour consistency.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 16, 2024
@SamuXarick
Fix OpenTTD#12228: Don't restrict path when checking ship reverse on …
4057816 
…first attempt

Try to mimic the same path results as ChooseShipTrack to maintain behaviour consistency.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 16, 2024
@SamuXarick
Fix OpenTTD#12228: Don't restrict path when checking ship reverse on …
d6584c1 
…first attempt

Try to mimic the same path results as ChooseShipTrack to maintain behaviour consistency.
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Mar 18, 2024
@Kuhnovic
Fix OpenTTD#12228, OpenTTD#12231, OpenTTD#12333: Ship pathfinder alwa…
eab94a0 
…ys considered reversing
@Kuhnovic Kuhnovic mentioned this issue Mar 18, 2024
Closed
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Mar 19, 2024
@Kuhnovic
Fix OpenTTD#12228, Fix OpenTTD#12231, Fix OpenTTD#12333: Ship pathfin…
061fe41 
…der always considers reversing
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Apr 5, 2024
@Kuhnovic
Fix OpenTTD#12228, Fix OpenTTD#12231, Fix OpenTTD#12333: Ship pathfin…
a757935 
…der always considers reversing
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Apr 10, 2024
@Kuhnovic
Fix OpenTTD#12228, Fix OpenTTD#12231: CheckShipReverse only restricts…
b1cc826 
… path when it has to
@Kuhnovic Kuhnovic mentioned this issue Apr 10, 2024
Merged
Kuhnovic added a commit that referenced this issue Apr 16, 2024
@Kuhnovic
Fix #12228, Fix #12231: CheckShipReverse only restricts path when it …
257d312 
…has to
glx22 pushed a commit to glx22/OpenTTD that referenced this issue Apr 18, 2024
@Kuhnovic @glx22
Fix OpenTTD#12228, Fix OpenTTD#12231: CheckShipReverse only restricts…
a254397 
… path when it has to
glx22 pushed a commit to glx22/OpenTTD that referenced this issue Apr 18, 2024
@Kuhnovic @glx22
Fix OpenTTD#12228, Fix OpenTTD#12231: CheckShipReverse only restricts…
a69edc8 
… path when it has to
glx22 pushed a commit that referenced this issue Apr 20, 2024
@Kuhnovic @glx22
Fix #12228, Fix #12231: CheckShipReverse only restricts path when it …
6359d5e 
…has to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@SamuXarick