Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12228, Fix #12231: CheckShipReverse only restricts path when it has to #12474

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Kuhnovic
Copy link
Contributor

@Kuhnovic Kuhnovic commented Apr 10, 2024

Motivation / Problem

Fixes #12228 and #12231

Description

Essentially a watered down version of #12335, in which I tried to fix too many things as once which caused annoying side effects.

CheckShipReverse now calls ChooseShipTrack instead of implementing a lot of the logic twice, which should make the code a bit cleaner.

Limitations

None that I'm aware of

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@Kuhnovic Kuhnovic merged commit 257d312 into OpenTTD:master Apr 16, 2024
14 checks passed
@Kuhnovic Kuhnovic deleted the ship_pf_fix_reversal_restriction branch April 16, 2024 18:21
@Kuhnovic Kuhnovic added the backport requested This PR should be backport to current release (RC / stable) label Apr 16, 2024
@glx22 glx22 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CheckShipReverse's returned path restricts ship movement, causing it to get lost
3 participants