Fix #12228, Fix #12231: CheckShipReverse only restricts path when it has to #12474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Fixes #12228 and #12231
Description
Essentially a watered down version of #12335, in which I tried to fix too many things as once which caused annoying side effects.
CheckShipReverse now calls ChooseShipTrack instead of implementing a lot of the logic twice, which should make the code a bit cleaner.
Limitations
None that I'm aware of
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.