Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing colon and extra ending dots in English base language #12255

Closed
pasantoro opened this issue Mar 10, 2024 · 3 comments · Fixed by #12262
Closed

[Bug]: Missing colon and extra ending dots in English base language #12255

pasantoro opened this issue Mar 10, 2024 · 3 comments · Fixed by #12262

Comments

@pasantoro
Copy link

Version of OpenTTD

nightly (20240308), Linux Mint 21.3

Expected result

I think that I found some missing characters and some additional ones in the English base language.

One missing colon after 'windows' word (before {STRING2})
STR_CONFIG_SETTING_SHOW_CARGO_IN_LISTS :Show the cargoes the vehicles can carry in the list windows {STRING2}

Some TOOLTIP strings have a period at the end that should not be there (11 out of 659)
Some HELPTEXT strings have a period at the end that should not be there (33 out of 213)

Actual result

TOOLTIP and HELPTEXT type strings should not have a period at the end.

Steps to reproduce

The attached file contains what I believe to be the errors as they appear in the text file that is
obtained by using the "Download Lang File" button at Web Translator - OpenTTD webpage.
missing-extra_chars_en-GB_lang_OpenTTD.txt

@merni-ns
Copy link
Contributor

It may be more useful to submit a Pull Request with the proposed changes (which can probably be done in the github website itself for such a simple change). The base English lang file is at src/lang/english.txt. Make sure to read these guidelines first.

@pasantoro
Copy link
Author

It may be more useful to submit a Pull Request with the proposed changes (which can probably be done in the github website itself for such a simple change). The base English lang file is at src/lang/english.txt. Make sure to read these guidelines first.

Thanks, but I am submitting a "bug" report because I don't know how to do a Pull Request.

@pasantoro
Copy link
Author

Thank you very much for your time and kind help.

michicc pushed a commit to michicc/OpenTTD that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants