Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12255: inconsistent punctuation in English #12262

Merged
merged 1 commit into from Mar 10, 2024

Conversation

rubidium42
Copy link
Contributor

Motivation / Problem

Fixes #12255.
Inconsistent trailing periods in help and tooltip texts, made consistent by taking the majority 'choice', i.e. no trailing periods.
There's also one missing semi-colon.

Description

Update the strings appropriately.

Limitations

Might trigger a lot of "changed" strings for translators, but that's not really a reason to be inconsistent.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 added the backport requested This PR should be backport to current release (RC / stable) label Mar 10, 2024
@rubidium42 rubidium42 merged commit 2f0fe22 into OpenTTD:master Mar 10, 2024
18 checks passed
@rubidium42 rubidium42 deleted the fix-12255 branch March 10, 2024 15:51
@michicc michicc added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing colon and extra ending dots in English base language
3 participants