Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2: IME input problem for non-english language on Linux #7810

Open
SJang1 opened this issue Oct 29, 2019 · 2 comments
Open

SDL2: IME input problem for non-english language on Linux #7810

SJang1 opened this issue Oct 29, 2019 · 2 comments

Comments

@SJang1
Copy link

@SJang1 SJang1 commented Oct 29, 2019

Version of OpenTTD

tested on 1.10.0-beta1

Expected result

Inputs Correctly with non-english languages too.

Actual result

Cannot change language.

Steps to reproduce

(for me, I am using hangul(Korean))
Environment : Fedora 31, using fcitx+fcitx-hangul as an input method

  1. build openttd
  2. run it
  3. try to change language (to hangul)
    => It doesn't change, No message on terminal.
    (If trying to change with hangul key on keyboard, getting The key you just pressed is not recognized by SDL. To help get this fixed, please report this to the SDL forums/mailing list <https://discourse.libsdl.org/> X11 KeyCode 130 (122), X11 KeySym 0xFF31 (Hangul).

This had been fixed on JGRennison/OpenTTD-patches ( issue : JGRennison/OpenTTD-patches#100 )

@nikolas
Copy link
Member

@nikolas nikolas commented Nov 3, 2019

It looks like @JGRennison added IME support to the SDL 2 driver (which wasn't possible in SDL 1). It would be great to get this into OpenTTD-master. I don't have any experience with IME or fcitx. It looks like his changes to the SDL driver may also fix #7816.

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Nov 3, 2019

#7816 is really the same as #7783, which does not require anything complicated to fix.

The fcitx IME changes I made were notably more non-trivial than I expected when I started, and may not necessarily be the approach you want to take with trunk.
The IME support already in SDL2 is more limited in various ways but is not that complicated to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants