Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: File list mouse hover behaviour. #10040

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Sep 21, 2022

Motivation / Problem

File list mouse hover highlight is visible even if the mouse pointer was in a different window.

Description

Resolved by using OnMouseOver() instead of OnMouseLoop(), as done for the Online Players window.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Hover highlight was visible even if the mouse pointer was in a different
window. Resolved by using OnMouseOver() instead of OnMouseLoop().
@PeterN PeterN merged commit 607ef09 into OpenTTD:master Sep 21, 2022
@PeterN PeterN deleted the file-list-hover branch September 21, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants