Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 03cc0d6: Mark level crossings dirty when removing road from them, not from bridges #10138

Merged
merged 1 commit into from Nov 5, 2022

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

In 03cc0d6 / #9931 I introduced an assertion failure when removing road or tram from a shared bridge, reported as #10133.

When upstreaming the JGRPP implementation of this feature, I pasted a line of code into the wrong, but similar-looking place in RemoveRoad.

Instead of updating adjacent level crossings when removing road from a level crossing tile, it is done when removing road from a bridge tile.

Description

Put the code in the right place.

Closes #10133.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@2TallTyler 2TallTyler added the size: trivial This Pull Request is trivial label Nov 5, 2022
@2TallTyler 2TallTyler merged commit c719ba5 into OpenTTD:master Nov 5, 2022
@2TallTyler 2TallTyler deleted the remove_road branch November 5, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: trivial This Pull Request is trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Assert when removing road or tram tracks from a shared road/tram bridge
2 participants