Codechange: do not declare functions in blocks #10429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
CodeQL alerting about functions being declared in blocks. Specifically that even if you declare them in a block, they will become available globally.
Description
Either remove it because it was already declared outside the block, move it to the "global" scope of the cpp file or add the function to a reasonably appropriate header file.
Limitations
None.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.