Codechange: move curl into a thread so simplify code #10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Feb 14, 2023
TrueBrain
force-pushed
the
curl-in-thread
branch
from
9d5f8c5
to
53f6f6e
Compare
frosch123
previously approved these changes
Feb 14, 2023
TrueBrain
force-pushed
the
curl-in-thread
branch
from
53f6f6e
to
8ffa19d
Compare
rubidium42
reviewed
Feb 15, 2023
frosch123
reviewed
Feb 15, 2023
With a thread, we can just run curl_easy_perform() and let CURL and threads handle the blocking part. With async solution there are too many things to keep track of, and it makes "when to update the GUI" tricky. By using a thread that all gets a lot simpler, as the game-thread and download-thread run side-by-side. This is similar to how the WinHttp backend already works.
TrueBrain
force-pushed
the
curl-in-thread
branch
from
8ffa19d
to
5fcd03e
Compare
frosch123
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The async variant of curl gave too much trouble / noise. Switching to a threaded/sync solution brings it on-par with WinHttp, and makes the code a lot easier.
Description
With a thread, we can just run curl_easy_perform() and let CURL and threads handle the blocking part.
With async solution there are too many things to keep track of, and it makes "when to update the GUI" tricky. By using a thread that all gets a lot simpler, as the game-thread and download-thread run side-by-side.
This is similar to how the WinHttp backend already works.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.