Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codechange: move curl into a thread so simplify code #10480

Merged
merged 1 commit into from Feb 15, 2023
Merged

Codechange: move curl into a thread so simplify code #10480

merged 1 commit into from Feb 15, 2023

Commits on Feb 15, 2023

  1. Codechange: move curl into a thread so simplify code 

    With a thread, we can just run curl_easy_perform() and let CURL
and threads handle the blocking part.

With async solution there are too many things to keep track of,
and it makes "when to update the GUI" tricky. By using a thread
that all gets a lot simpler, as the game-thread and download-thread
run side-by-side.

This is similar to how the WinHttp backend already works.
    @TrueBrain
    TrueBrain committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    5fcd03e View commit details
    Browse the repository at this point in the history