Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10486: [Script] Debug window requires AIs to be started before GS #10487

Merged
merged 1 commit into from Feb 17, 2023
Merged

Fix #10486: [Script] Debug window requires AIs to be started before GS #10487

merged 1 commit into from Feb 17, 2023

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Feb 16, 2023 •
edited

Fixes #10486

Motivation / Problem

When loading a savegame, if the GS crashes on start, the debug window is opened and it defaults to the first AI (is_ai == true).
But at that point of loading, the AIs are not started yet so no instance => crash.

Description

Start the AIs before GS.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Feb 16, 2023
@glx22 glx22 merged commit 4072dcf into OpenTTD:master Feb 17, 2023
@glx22 glx22 deleted the fix_10486 branch February 17, 2023 11:25
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Mar 26, 2023
@glx22 @rubidium42
Fix OpenTTD#10486: [Script] Debug window requires AIs to be started b…
2ba4370 
…efore GS (OpenTTD#10487)
@rubidium42 rubidium42 mentioned this pull request Mar 26, 2023
Merged
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Mar 28, 2023
@glx22 @rubidium42
Fix OpenTTD#10486: [Script] Debug window requires AIs to be started b…
a4c92c7 
…efore GS (OpenTTD#10487)
rubidium42 pushed a commit that referenced this pull request Mar 31, 2023
@glx22 @rubidium42
Fix #10486: [Script] Debug window requires AIs to be started before GS (
0604f57 
#10487)
@rubidium42 rubidium42 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Crash]: Loaded savegame, crashed
3 participants
@glx22 @LordAro @rubidium42