Fix: store autosave settings under the new names #11143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
autosave-setting
branch
3 times, most recently
from
d04f459
to
8b2a4c6
Compare
TrueBrain
force-pushed
the
autosave-setting
branch
2 times, most recently
from
b2c5145
to
1f6c873
Compare
|
This will make my 'allow any value' patch a lot simpler 😍 |
PeterN
reviewed
Jul 19, 2023
TrueBrain
force-pushed
the
autosave-setting
branch
4 times, most recently
from
066a465
to
7467830
Compare
…s once By forcing it only happens once, the first time you upgrade to a newer client, means you are free to jump between older and newer versions after that. As they will not resync, the newer setting can take on any of the (newer) values, without breaking the old client. And when going to an old client and back, it doesn't change it back to the converted value anymore.
TrueBrain
force-pushed
the
autosave-setting
branch
from
7467830
to
9737eaf
Compare
PeterN
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
While looking for a way to allow aliases for
OMANY, I noticed autosave was storing the wrong settings values. And that we have a way to allow aliases.Description
Instead of storing the old
monthly,yearly, etc, store it in minutes.This keeps the original setting in tact, and renames the new one. This allows switching back between old and new versions without annoying warnings.
Based on comments and feedback, this PR grew a bit bigger to supply a framework for future conversions too. Also makes it a bit more readable :)
Limitations
The GUI doesn't allow for anything between the predefined settings. This means if the user changes the value in the config to something other than 0/10/30/60/120, it will work, till the Game Options are opened again.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.