Codechange: wire "load" support into all OMANY and MMANY for settings #11144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
While working on #11143 I had some arguments with the code in respect to
load
and OMANY.Description
This PR fixes so that
load
works for allOMANY
(andMMANY
). Nobody actually uses it, so you can argue if this PR should be merged, but the current code was silly.While at it, also reworked the logic slightly, that it first tries to use the lookup, next the conversion, and only after that check if it is a digit. The original code did the digit first, which meant you can't do a lookup starting with a number.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.