Codechange: Rearrange (code) of AI/GS debug window.

[PeterN]

Motivation / Problem

The AI/GS debug window updated its state as it was drawn, and would redraw again if some state had changed.

Many widgets were drawn in OnPaint() instead of DrawWidget(), and the company icon was drawn incorrect based on unscaled hardcoded pixel dimensions.

Description

Instead, update state either during OnInvalidateData or before any drawing commences, and draw everything through DrawWidget() handler, via smaller class methods to break it up.

Additionally the "Game Script" button is moved next to the Company/AI selector which makes it more obvious that it is part of the same exclusive toggle.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR touches english.txt or translations? Check the guidelines
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, game_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker

[2TallTyler]

The padding around the company and script buttons looks strange to me -- it's all very busy and crammed up against the bar below containing the script name, the settings button, and the reload button. I wonder if increasing (or maybe eliminating) said padding would help with the visual confusion.

I know that's out of scope, but since you're there anyway... (Feel free to say "another PR" or "do it yourself" 😛)

[PeterN]

The padding around the company and script buttons looks strange to me -- it's all very busy and crammed up against the bar below containing the script name, the settings button, and the reload button. I wonder if increasing (or maybe eliminating) said padding would help with the visual confusion.

I know that's out of scope, but since you're there anyway... (Feel free to say "another PR" or "do it yourself" 😛)

I did adjust it from uneven padding where it overlaps or touches borders, so the style used on the Detailed Performance Rating window.

The only other place with this style of list is the Cargo Flow Legend window, which still has touching borders (because I've not touched it yet) so... dunno.

Maybe the button row below could go above the company buttons, or at the bottom with the other buttons. Hmm.

[glx22]

Main issue in this window is the number of "tabs"

Maybe the 2 rows of 8 companies (with the empty space because there are only 15) could be replaced with 3 rows of 5.
At least it could allow to pack company buttons and game script button, giving some space on their right which could be filled with a frame for script name and and the 2 buttons.

Another option to keep the tab style is to put tabs in a single column on the left.

It's very hard for this window to look "nice".

[PeterN]

All layout changes have been undone, as it seems people would rather have a full redesign than a minor tweak.

[2TallTyler]

Sorry, I wasn't trying to argue that your layout change wasn't an improvement. 😦

This might need a new commit title when merging, because it's now a codechange rather than a change. Maybe Codechange: Refactor AI/GS debug window.