Fix: don't use non-owning string pointer in StringParameter #11952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Fixes #11922
The string pointer can become invalid before the reference is dropped, causing out-of-bound access in windows like ErrorWindow, or when closing the game.
Description
Instead of referencing a string, copy it. That way we know it is always safe.
Backported from JGRPP.
This is more a stop-gap solution, to remove the issue for upcoming release. Better solutions might be presented at a later stage.
Limitations
More memory usage when a pointer was used.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.