Fix: Off-by-one in EnsureVisibleCaption. #12261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Mar 10, 2024
An off-by-one in EnsureVisibleCaption causes the minimum visible caption height to be 13 scaled pixels and 1 unscaled pixel. At 1x interface scale, this 'happens' to be the complete height of a caption, but at other interface scales it is not. Instead of using a scaled fixed value, correct the off-by-one and just use the window's actual caption height instead.
PeterN
force-pushed
the
fix-ensure-visible-caption
branch
from
877af2a
to
1720de8
Compare
LordAro
approved these changes
Mar 10, 2024
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Mar 16, 2024
An off-by-one in EnsureVisibleCaption causes the minimum visible caption height to be 13 scaled pixels and 1 unscaled pixel. At 1x interface scale, this 'happens' to be the complete height of a caption, but at other interface scales it is not. Instead of using a scaled fixed value, correct the off-by-one and just use the window's actual caption height instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
An off-by-one in EnsureVisibleCaption causes the minimum visible caption height to be 13 scaled pixels and 1 unscaled pixel. At 1x interface scale, this 'happens' to be the complete height of a caption, but at other interface scales it is not.
Description
Instead of using a scaled fixed value, correct the off-by-one and just use the window's actual caption height instead.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.