Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Off-by-one in EnsureVisibleCaption. #12261

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Fix: Off-by-one in EnsureVisibleCaption. #12261

merged 1 commit into from
Mar 10, 2024

Commits on Mar 10, 2024

  1. Fix: Off-by-one in EnsureVisibleCaption. 

    An off-by-one in EnsureVisibleCaption causes the minimum visible caption height to be 13 scaled pixels and 1 unscaled pixel. At 1x interface scale, this 'happens' to be the complete height of a caption, but at other interface scales it is not.

Instead of using a scaled fixed value, correct the off-by-one and just use the window's actual caption height instead.
    @PeterN
    PeterN committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    1720de8 View commit details
    Browse the repository at this point in the history