Codechange: Remove CDECL from filter functions. #12578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
GUIList sort functions were originally eventually passed to qsort, so had CDECL slapped on them.
This has not been the case for long a time, so this is not necessary.
Description
These functions are passed to std::sort() these days, and should not need any special calling convention, so removing CDECL.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.