Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Add flag and railtype sprite type to draw pre-combined ground sprites. #7231

Merged
merged 1 commit into from Mar 9, 2019

Conversation

@PeterN
Copy link
Member

PeterN commented Feb 14, 2019

This allows a NewGRF rail type to provide all combinations of track junctions itself, in case the default method of overlaying parts is unsatisfactory. This is an all-or-nothing flag, so all combinations must be provided if set.

This is a feature possibly requested long ago. It has not been tested and as far as I know no test-case currently exists.

@PeterN PeterN added wip and removed wip labels Feb 14, 2019
@PeterN
Copy link
Member Author

PeterN commented Feb 21, 2019

This is not a WIP, however it would need to be confirmed by testing.

@andythenorth andythenorth added the NewGRF label Mar 2, 2019
@PeterN PeterN added the needs testing label Mar 7, 2019
@PeterN PeterN marked this pull request as ready for review Mar 7, 2019
@michicc
michicc approved these changes Mar 8, 2019
Copy link
Member

michicc left a comment

No idea if it's feasible in practice to make sprites for this, but the code looks sound.

@PeterN
Copy link
Member Author

PeterN commented Mar 8, 2019

Mmm, it's simply 63 sprites for all-but-one combinations. I'll try cobbling something together.

@PeterN PeterN merged commit 42046af into OpenTTD:master Mar 9, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190214.11 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@PeterN PeterN deleted the PeterN:railtype-nocombine branch Mar 9, 2019
@andythenorth
Copy link
Contributor

andythenorth commented Mar 9, 2019

This or similar was requested by Pikka for #5132

@PeterN
Copy link
Member Author

PeterN commented Mar 9, 2019

I spoke to another author recently who also expressed interest in this feature, so I made a test NewGRF. Wiki has been updated as well.

nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
douiwby added a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.