Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid using stat to retrieve file modification times on Windows (#7731) #7736

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@orudge
Copy link
Contributor

commented Sep 11, 2019

Arguable whether it's worth the effort fixing this one, but the attached changes fix the issue reported in #7731. I've tested with MSVC 2019 and a Windows XP VM and the file sorting works correctly. Since our builds do still work on XP SP3 it doesn't seem unreasonable to fix issues that are straightforward, but I would maintain that XP is still very much unsupported at this stage!

src/fios.cpp Outdated Show resolved Hide resolved

@orudge orudge force-pushed the orudge:master branch from 49f965d to 28b7ecd Sep 11, 2019

@planetmaker
Copy link
Contributor

left a comment

I have little ability to test that myself, but see no reason to not approve, if it works.

@orudge orudge merged commit 165eae0 into OpenTTD:master Sep 13, 2019

8 checks passed

OpenTTD CI Build #20190911.3 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@nielsmh nielsmh referenced this pull request Sep 16, 2019
@sirkoz

This comment has been minimized.

Copy link

commented Sep 18, 2019

A big thank you to all involved to make this happen. They live! (XP machines that is) :-)

@LordAro

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

But they really shouldn't! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.