Backport things for 1.10.3 release #8287
NetworkTCPSocketHandler::SendPacket is not thread safe and may not be used concurrently from multiple threads without suitable locking
Remove static buffer form of NetworkAddress::GetAddressAsString. This is used in multiple threads concurrently, and is not thread-safe. Replace it with a form returning std::string.
conected and aborted flags are used concurrently from multiple threads.
This changes the error when you attempt to convert a road owned by a town to another road, specifying that it's owned by the town rather than simply being incompatible. As the original poster of the issue pointed out, these seemed to be the only occurences of the incompatible road string, so now it's unused, but they would be left untouched in case of future use or since changing it to a different error would do the work of removing it then. If requested, it likely wouldn't be too difficult to remove the string entirely.
This could be caused by an engine being renamed, and the old name being cached from a previous sort. See: #7838
This could be caused by a group being renamed, and the old name being cached from a previous sort. See: #7838
…tead of using desync-prone town caches
LordAro merged commit
Aug 9, 2020
8 checks passed
8 checks passed
OpenTTD CI Build #20200809.1 succeededDetails
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeededDetails
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeededDetails
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeededDetails
OpenTTD CI (MacOS) MacOS succeededDetails
OpenTTD CI (Windows Win32) Windows Win32 succeededDetails
OpenTTD CI (Windows Win64) Windows Win64 succeededDetails
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.