Fix 2db88953: default Network Server List sorter put compatible servers in wrong order #8626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
A user on IRC reported a very vague problem (as in, it was not understandable), but luckily is triggered @ldpl .. turns out that the whole 1.10 series had the default sorter sorting wrong. Honest mistake in a codechange commit, simple fix. For some reason nobody had done so, so here we are.
Description
If a server is compatible, it falls back to sorting by clients.
This used to be in reverse, so full servers are on top. With
the codechange commit, this was removed by accident, and as
such empty servers were on top. This is silly.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.