Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove old FiosList helper methods. #9139

merged 1 commit into from Apr 29, 2021


Copy link

@PeterN PeterN commented Apr 29, 2021

Motivation / Problem

FiosList class is a wrapper around std::vector with some compatibility methods added to support the old SmallVector-style callers. This is legacy and not necessary.


This change removes the crufty helpers, makes FiosList directly inherit of std::vector, and use the native std::vector methods and range iteratoers.


There is one section that should be a range iterator, but it seems not to work via "this".

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
src/fios.cpp Outdated Show resolved Hide resolved
src/fios.cpp Outdated Show resolved Hide resolved
@PeterN PeterN force-pushed the remove-fios-helper branch from b31a660 to 4d68e9f Apr 29, 2021
glx22 approved these changes Apr 29, 2021
@PeterN PeterN merged commit f018471 into OpenTTD:master Apr 29, 2021
12 checks passed
@PeterN PeterN deleted the remove-fios-helper branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants