Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Be more selective when marking windows dirty #9204

Merged
merged 2 commits into from May 8, 2021

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented May 7, 2021

Motivation / Problem

Whilst debugging window layouts I noticed that there some places where whole windows are marked dirty when in fact only one widget needs to be drawn. This is not really an issue but I had an itch.

Description

Some actions that previously marked a window dirty now only mark the relevant widget dirty.
Scrollbar behaviour has been tweaked so that if the scrollbar position is not changed, no update is performed.

Limitations

Fairly sure this is no where near all cases...

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@michicc
michicc approved these changes May 7, 2021
@PeterN PeterN merged commit 52b1623 into OpenTTD:master May 8, 2021
11 checks passed
11 checks passed
@github-actions
Emscripten
Details
@github-actions
Commit checker
Details
@github-actions
Linux (clang, clang++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl1.2-dev)
Details
@github-actions
Linux (gcc, g++, -DOPTION_DEDICATED=ON)
Details
@github-actions
Mac OS (x64, x86_64)
Details
@github-actions
Windows (windows-latest, x86)
Details
@github-actions
Windows (windows-latest, x64)
Details
@github-actions
Windows (windows-2016, x86)
Details
@github-actions
Windows (windows-2016, x64)
Details
@PeterN PeterN deleted the PeterN:less-dirty branch May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants