Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Language Definitions: Split zh_TW into zh_TW and zh_HK #9801

Closed
wants to merge 3 commits into from
Closed

Change Language Definitions: Split zh_TW into zh_TW and zh_HK #9801

wants to merge 3 commits into from

Conversation

wpi3
Copy link

@wpi3 wpi3 commented Jan 25, 2022

Motivation / Problem

There is a considerable amount of difference in terms of vocabulary and grammar between zh_TW and zh_HK. The current translations follows zh_TW standard and ignores zh_HK users, who would find the translations unnatural and too formal, and even uses some vocabulary unique to zh_TW users but not understood by zh_HK users.

There are also some differences in the written forms. By splitting the two, the OS can better choose the correct glyphs to display when the correct language codes are used.

Description

Add a separate txt for zh_HK and change the name and ownname of the traditional_chinese.txt to refer to Taiwan rather than Traditional Chinese.

Limitations

  • Changing name and ownname might break stuff with the web translator?
  • The grflangid of zh_HK is left blank, as I'm not sure what to fill in there, though it seems arbitary to me

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@wpi3 wpi3 changed the title Split zh_TW into zh_TW and zh_HK Change Language Definitions: Split zh_TW into zh_TW and zh_HK Jan 25, 2022
@frosch123
Copy link
Member

I forwarded the request to the translation team. Let's see whether there is interest in maintaining another translation.

@wpi3
Copy link
Author

wpi3 commented Mar 9, 2022

@frosch123 Any updates on this?
Also, to make it clear, I'm native in zh_HK and willing to do the translation.

@frosch123
Copy link
Member

@wpi3 There was no reply from the translators on this.

Statistics for zh_TW:

So, translation activity is currently not sufficient to keep up with 100% translation status.

Maintaing a translation requires quite some effort, you may you would like to sign up for zh_TW translations first to familarize yourself with the WebTranslator.
Sign-up is here: https://github.com/OpenTTD/team/issues/new/choose

@wpi3 wpi3 deleted the branch OpenTTD:master May 24, 2022 10:31
@wpi3 wpi3 closed this May 24, 2022
@wpi3 wpi3 deleted the master branch May 24, 2022 10:31
@wpi3 wpi3 restored the master branch May 24, 2022 10:32
@wpi3 wpi3 deleted the master branch May 24, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants