Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: change the login flow to an OAuth2 PKCE flow #15

Merged
merged 5 commits into from Apr 19, 2020
Merged

Fix: change the login flow to an OAuth2 PKCE flow #15

merged 5 commits into from Apr 19, 2020

Commits on Apr 19, 2020

  1. Fix: change the login flow to an OAuth2 PKCE flow 

    This avoids other websites being able to steal API tokens and
modify any content on the API, without the user knowing.
    @TrueBrain
    TrueBrain committed Apr 19, 2020
    Copy the full SHA
    2b9e143 View commit details
    Browse the repository at this point in the history

  2. Add: validate client-id and redirect-uri during authentication 

    If people want to register their application, they can make a
pull-request. This follows OAuth2 design, although we don't have
a dynamic portal to register your app, but it needs to be done
via a pull-request.
    @TrueBrain
    TrueBrain committed Apr 19, 2020
    Copy the full SHA
    8959f0a View commit details
    Browse the repository at this point in the history

  3. Fix: reworked the developer login method; it now asks for a username

    @TrueBrain
    TrueBrain committed Apr 19, 2020
    Copy the full SHA
    a43c546 View commit details
    Browse the repository at this point in the history

  4. Fix: typos and black/flake errors

    @TrueBrain
    TrueBrain committed Apr 19, 2020
    Copy the full SHA
    4850896 View commit details
    Browse the repository at this point in the history

  5. Fix: update regression with new developer login-flow

    @TrueBrain
    TrueBrain committed Apr 19, 2020
    Copy the full SHA
    b903c15 View commit details
    Browse the repository at this point in the history