Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bugs found while bringing this to production #4

Merged
merged 4 commits into from Sep 10, 2020
Merged

Several bugs found while bringing this to production #4

merged 4 commits into from Sep 10, 2020

Commits on Sep 8, 2020

  1. Add: a small HTTP server to check health-status 

    This helps in deployments to AWS to know if the server is done
starting up.
    @TrueBrain
    TrueBrain committed Sep 8, 2020
    Copy the full SHA
    cae5606 View commit details
    Browse the repository at this point in the history

  2. Fix: [Actions] deploy both the server and the API at the same time

    @TrueBrain
    TrueBrain committed Sep 8, 2020
    Copy the full SHA
    e39a16b View commit details
    Browse the repository at this point in the history

  3. Fix: don't close() transport, as the webserver has killed the event-loop 

    aiohttp has this odd thing that it closes down the event-loop it
is running in. This includes the transports. So by the time we exit
from the run() function, those transports are already long gone.
    @TrueBrain
    TrueBrain committed Sep 8, 2020
    Copy the full SHA
    36d1578 View commit details
    Browse the repository at this point in the history

  4. Fix: implement proxy protocol properly for UDP 

    Turns out, only the first package of a stream contains the proxy
protocol header when using nginx. So we need to track the mapping.
    @TrueBrain
    TrueBrain committed Sep 8, 2020
    Copy the full SHA
    005c756 View commit details
    Browse the repository at this point in the history