Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for rail vehicle property 0x2E, curve_speed_mod #222

Merged
merged 1 commit into from Aug 15, 2021

Conversation

@vituscze
Copy link
Contributor

@vituscze vituscze commented Jun 12, 2021

Depends on OpenTTD/OpenTTD#9346

Also adds support for the related 0x36 callback.
@michicc
Copy link
Member

@michicc michicc commented Aug 15, 2021

Might be fine. Negative values are correctly translated and the scaling factor seems to fit, too.

Loading

Copy link
Contributor

@andythenorth andythenorth left a comment

Based on Michi's comment, approving. The only area of concern was 255 vs 256 for unit conversion (don't know which is correct).

Loading

Copy link
Contributor

@FLHerne FLHerne left a comment

From when we discussed this on IRC, I'm fairly sure 256 is correct. If it isn't, it's already wrong for several other properties with the same value range and would need fixing anyway.

Loading

@FLHerne FLHerne merged commit 9ec112c into OpenTTD:master Aug 15, 2021
21 checks passed
Loading
@vituscze vituscze deleted the curve-speed branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants