Feature: Support for rail vehicle property 0x2E, curve_speed_mod - #222
Merged
Merged
Conversation
Also adds support for the related 0x36 callback.
Member
|
Might be fine. Negative values are correctly translated and the scaling factor seems to fit, too. |
andythenorth
approved these changes
Aug 15, 2021
andythenorth
left a comment
andythenorth
left a comment
Contributor
There was a problem hiding this comment.
Based on Michi's comment, approving. The only area of concern was 255 vs 256 for unit conversion (don't know which is correct).
FLHerne
approved these changes
Aug 15, 2021
FLHerne
left a comment
FLHerne
left a comment
Contributor
There was a problem hiding this comment.
From when we discussed this on IRC, I'm fairly sure 256 is correct. If it isn't, it's already wrong for several other properties with the same value range and would need fixing anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OpenTTD/OpenTTD#9346