Support extended object/station/roadstop limits (draft) #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled my FIRS test fine.
|
|
Seems you are using an outdated |
|
I'm using no such thing at all :-) |
glx22
reviewed
May 12, 2023
nml/actions/action0.py
Outdated
| @@ -194,7 +194,7 @@ def find_unused(self, length): | |||
| BlockAllocation(88, 0xFFFF, "Road Vehicle"), | |||
| BlockAllocation(11, 0xFFFF, "Ship"), | |||
| BlockAllocation(41, 0xFFFF, "Aircraft"), | |||
| BlockAllocation(0, 255, "Station"), | |||
| BlockAllocation(0, 0xFFFE, "Station"), # UINT16_MAX - 1 | |||
There was a problem hiding this comment.
Suggested change
| BlockAllocation(0, 0xFFFE, "Station"), # UINT16_MAX - 1 | |
| BlockAllocation(0, 0xFFFE, "Station"), # UINT16_MAX - 1 |
nml/actions/action0.py
Outdated
| @@ -205,12 +205,12 @@ def find_unused(self, length): | |||
| BlockAllocation(0, -1, "Sound"), | |||
| BlockAllocation(0, 127, "Airport"), | |||
| BlockAllocation(0, -1, "Signal", False), | |||
| BlockAllocation(0, 255, "Object"), | |||
| BlockAllocation(0, 0xF9FF, "Object"), # 64000 | |||
There was a problem hiding this comment.
Suggested change
| BlockAllocation(0, 0xF9FF, "Object"), # 64000 | |
| BlockAllocation(0, 64000, "Object"), |
There was a problem hiding this comment.
In fact just s/0xF9FF/64000/ and remove the comment would do.
nml/actions/action0.py
Outdated
| BlockAllocation(0, 63, "Railtype"), | ||
| BlockAllocation(0, 255, "Airport Tile"), | ||
| BlockAllocation(0, 62, "Roadtype"), | ||
| BlockAllocation(0, 62, "Tramtype"), | ||
| BlockAllocation(0, 255, "RoadStop"), | ||
| BlockAllocation(0, 0xFFFE, "RoadStop"), # UINT16_MAX - 1 |
There was a problem hiding this comment.
Suggested change
| BlockAllocation(0, 0xFFFE, "RoadStop"), # UINT16_MAX - 1 | |
| BlockAllocation(0, 0xFFFE, "RoadStop"), # UINT16_MAX - 1 |
PeterN
force-pushed
the
extendedbyte-action3
branch
from
23571f7
to
f6904c1
Compare
glx22
approved these changes
May 14, 2023
|
Added to nml spec https://newgrf-specs.tt-wiki.net/wiki/NML:Objects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, support for OpenTTD/OpenTTD#10672