Fix cleanup leaving generated files behind #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents hardcoding the path to this command, so things stay working if it is ever changed. Also, this prepares for overriding the clean command next, which would otherwise require importing the deprecated and to be removed in py3.12 distutils package.
The setup.py file overrides the build step to generate parsetab.py and lextab.py, but does not clean them up. This adds an override to the clean step to remove them again. Note that this uses the distutils version of the command as a basis, since (unlike the build_py step) setuptools does not provide its own version of it but just uses the distutils version.
matthijskooijman
force-pushed
the
cleanup-fixes
branch
from
cb20eee
to
614b2a3
Compare
|
I've updated the PR, adding the first commit to prevent having to import |
glx22
approved these changes
Dec 1, 2023
|
Hm, it seems these changes were merged in 0.7.5, but were not mentioned in docs/changelog.txt. Should I have added a changelog line in my PR? Or was this just overlooked in the release? Maybe good to add it retroactively for future reference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes an issue with the Debian package, where running a build and then a clean should leave the source tree in the same state as it started in (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1045259).
I'm about to ship these patches as part of the 0.7.4 Debian package, but it would be better to fix these upstream.
I'm not 100% sure that hardcoding the filenames to delete in
setup.pyis ideal, but it is pragmatic and probably not worth the trouble delegating the deletion all the way into parser.py and tokens.py where the original filenames are defined.