Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup leaving generated files behind #312

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Fix cleanup leaving generated files behind #312

merged 3 commits into from
Dec 1, 2023

Commits on Nov 26, 2023

  1. Change: Let setuptools figure out the default build_py command 

    This prevents hardcoding the path to this command, so things stay
working if it is ever changed.

Also, this prepares for overriding the clean command next, which would
otherwise require importing the deprecated and to be removed in py3.12
distutils package.
    @matthijskooijman
    matthijskooijman committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    24e3db0 View commit details
    Browse the repository at this point in the history

  2. Fix: Clean up generated parser files 

    The setup.py file overrides the build step to generate parsetab.py and
lextab.py, but does not clean them up. This adds an override to the
clean step to remove them again.

Note that this uses the distutils version of the command as a basis,
since (unlike the build_py step) setuptools does not provide its own
version of it but just uses the distutils version.
    @matthijskooijman
    matthijskooijman committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    98ecc93 View commit details
    Browse the repository at this point in the history

  3. Fix: Clean up cache and .so files created by regression test

    @matthijskooijman
    matthijskooijman committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    614b2a3 View commit details
    Browse the repository at this point in the history