Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Do not limit section header to 500px #127

Merged
merged 1 commit into from Dec 28, 2019
Merged

Conversation

@Milek7
Copy link
Contributor

Milek7 commented Dec 28, 2019

No description provided.

@TrueBrain
Copy link
Member

TrueBrain commented Dec 28, 2019

Again, what are we fixing here? :) Please spend a bit more time on the pull requests so we understand what you are doing; makes this go a lot quicker :) Tnx!

@Milek7
Copy link
Contributor Author

Milek7 commented Dec 28, 2019

  1. For aesthetic reasons, it just looks off when headers end at arbitrary 500px width on About etc pages.
  2. It makes possible to change main content width without looking misaligned. (I was annoyed by this fixed image when playing with navbar changes)
@TrueBrain
Copy link
Member

TrueBrain commented Dec 28, 2019

Tnx!

With the current image it looks really ugly, as the repeating of the image is including the rounded borders. But I am sure @LordAro has some nice suggestions for that :D

@Milek7
Copy link
Contributor Author

Milek7 commented Dec 28, 2019

Hm, but I included cropped image in this PR, it should look fine.

@TrueBrain
Copy link
Member

TrueBrain commented Dec 28, 2019

Ah, sorry, missed that. Can you attach a screenshot of the main page and a subpage with the result? Makes it easier to judge what you did :)

@Milek7
Copy link
Contributor Author

Milek7 commented Dec 28, 2019

obraz
obraz

@LordAro LordAro merged commit 7f41238 into OpenTTD:master Dec 28, 2019
2 checks passed
2 checks passed
Docker build
Details
website Build #20191228.26 succeeded
Details
@TrueBrain
Copy link
Member

TrueBrain commented Dec 29, 2019

Tnx for the screenshots.

This introduced some slight OCD impulse on my side. Let me show it to you in a picture:

image
image

Padding left/right is not equal. Not sure what I considered worse :D 500px or this :P

Is this also something that is easy to solve?

@auge8472
Copy link
Contributor

auge8472 commented Dec 29, 2019

Padding left/right is not equal. Not sure what I considered worse :D 500px or this :P

It's the width of #section-full, that is limited to 770px. That way it doesn't fill the whole potential width of the main. Removing the rule for the fixed width of #section-full, it takes the necessary
pixels on the right side.

openttd-width

Screenshot taken from www.staging.openttd.org/about.html, disabled the width rule for #section-full with the developer tools of the browser.

See also #129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.