-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul/rewrite CONTRIBUTING.md #2019
Merged
InfinityGhost
merged 6 commits into
OpenTabletDriver:master
from
Sublimelime:add-more-info-contributing
Mar 7, 2022
Merged
Overhaul/rewrite CONTRIBUTING.md #2019
InfinityGhost
merged 6 commits into
OpenTabletDriver:master
from
Sublimelime:add-more-info-contributing
Mar 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change some wording around, format long lines, add clarification to config contribution area, add way more information to code contribution area
vedxyz
suggested changes
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive review huh
Co-authored-by: Ved <dev@vedat.xyz>
Suggested by vedattt
InfinityGhost
added
enhancement
New feature or request
meta
Dotfiles, scripts or Github files
labels
Feb 6, 2022
InfinityGhost
requested changes
Mar 3, 2022
vedxyz
suggested changes
Mar 3, 2022
Co-authored-by: Ved <dev@vedat.xyz>
InfinityGhost
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some wording around, formatted long lines, added clarification to
config contribution area, added way more information to code
contribution area.
Opened as draft to gather more feedback for now. Feel free to suggest additional things to add, correct me, etc.