-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match digitizer/aux parser and remove wild configs #910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these configurations changed have VID: null nor PID: null, only null InputReportLength and OutputReportLength. This is also a batch change for known working configurations, not sure if this is the best option.
Edited. Was a typo. The change regarding parsers are due to parsing overlap in certain parsers which caused the issue in #909. The other InputReportLength and OutputReportLength nulls will also cause problem for other tablets especially those that use it in aux. This PR will force us to fix these configurations rather than rely on "wild" matching. tl; dr, 909 happened because it opened the same endpoint using different parsers. |
Any resolution to this one? Would be great to be able to get it fixed at our end as right now this is causing bindings to be unusable (buttons are always reported as down). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might have to just approve this and revert if need be.
Anything stopping this from getting merged? |
Changes
Fixes #909