Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match digitizer/aux parser and remove wild configs #910

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

X9VoiD
Copy link
Member

@X9VoiD X9VoiD commented Mar 24, 2021

Changes

  • Match the parser used in aux with the digitizer's
  • Remove "wild" configs that identifies as InputReportLength: null, OutputReportLength: null. These configs match anything and causes overlaps

Fixes #909

@InfinityGhost InfinityGhost added this to the v0.5.3 milestone Mar 24, 2021
@InfinityGhost InfinityGhost added bug Something isn't working configuration Adds or modifies a tablet configuration labels Mar 24, 2021
Copy link
Member

@InfinityGhost InfinityGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these configurations changed have VID: null nor PID: null, only null InputReportLength and OutputReportLength. This is also a batch change for known working configurations, not sure if this is the best option.

@X9VoiD
Copy link
Member Author

X9VoiD commented Mar 24, 2021

Edited. Was a typo.

The change regarding parsers are due to parsing overlap in certain parsers which caused the issue in #909. The other InputReportLength and OutputReportLength nulls will also cause problem for other tablets especially those that use it in aux. This PR will force us to fix these configurations rather than rely on "wild" matching.

tl; dr, 909 happened because it opened the same endpoint using different parsers.

@peppy
Copy link

peppy commented Mar 29, 2021

Any resolution to this one? Would be great to be able to get it fixed at our end as right now this is causing bindings to be unusable (buttons are always reported as down).

Copy link
Member

@InfinityGhost InfinityGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to just approve this and revert if need be.

@gonX
Copy link
Member

gonX commented Apr 5, 2021

Anything stopping this from getting merged?

@InfinityGhost InfinityGhost merged commit 43a5bf5 into OpenTabletDriver:master Apr 6, 2021
@X9VoiD X9VoiD deleted the fix-configs branch April 6, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working configuration Adds or modifies a tablet configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTL-4100 Buttons always pressed after receiving positional input
4 participants