New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenGL 3.3 and less hate for Open Source drivers #131
Conversation
there are two extensions that are not from the core profile, but the engine seems to not use them (maybe are from the old idTech4 engine in Doom3 times)
the code doesn't seem to use those extensions any further than checking for their existence |
@DanielGibson comments? |
r_useOpenGL32 no longer exists now. |
confirmed: https://github.com/TTimo/doom3.gpl/blob/master/neo/renderer/Image_load.cpp#L276 as well as the usage of VertexBufferObjectAvailable in that case named ARBVertexBufferObjectAvailable in draw_r200.cpp (that's for OpenGL 1.3 limited Ati Radeon r200, this stuff is old! it can't play the BFG version of the engine) obiously no longer present in OpenTech nor doom3BFG: https://github.com/TTimo/doom3.gpl/blob/master/neo/renderer/draw_r200.cpp#L485 so both checks aren't used but make the code fail unneedlessly! |
oops I made a mistake in the commited source
the hell happened here!?
…ven newer ins some instances )
now it really works! I had a very stupid but important error in the code added by me, in which I forced it to run at OpenGL 3.x even if r_selectOpenGL had a higher value, and so while it used OpenGL 3.3 it never compiled the CG to anything further than GLSL ES. Now instead, it compiles the CG to both GLSL 1.5 and 3.3 following whatever r_selectOpenGL states. so now it works as it should! :) |
a more important change have happened since then, I'll be back with a future pull request! |
No description provided.