Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The List View does not capture who signed up to write a review for an application. #1109

Closed
fourthletter opened this issue Mar 13, 2019 · 8 comments
Assignees

Comments

@fourthletter
Copy link
Contributor

fourthletter commented Mar 13, 2019

The List View does not capture who signed up to write a review or intends to write a review in the future.

It is possible to know AFTER a review has been submitted, but this information is not available BEFORE a review has been submitted. It is also possible to see names of reviewers within the submission and in the detailed view, but it's not possible in the List View.

  • Managers need a quick view to know which applications need additional reviewers in order to assign multiple reviewers as a batch action.
  • Individuals need a quick view to know which applications need primary or secondary reviewers in order to select multiple applications as a batch action.
@frjo
Copy link
Contributor

frjo commented Mar 13, 2019

@fourthletter Is there a function where reviewers can sign up to review a specific submission? I do not know about it, or maybe you want such a feature added?

In the list view (I assume you mean https://apply.opentech.fund/apply/submissions/all/) it would be hard to fit a long list of reviewers like the one on submission detail view.

It would definitely need to be in the fold out section for each submission, but still hard to fit. Any ideas how it should look/work?

@arduina
Copy link

arduina commented Mar 13, 2019

@frjo in the fold out section would be fine. It would be great if you could see right away if there are not only review outcomes but reviewers assigned. In this view you also assign yourself by clicking the box left of the application and using the function above.
Right now you can't see if this project already has sufficient reviewers, so if you assign yourself, others are simply removed.

@frjo
Copy link
Contributor

frjo commented Mar 14, 2019

The batch add reviewers function on
https://apply.opentech.fund/apply/submissions/all/ is only for staff, reviewers can not access this view at all.

Are OTF staff using this to assign themselves to submissions? I thought this was the job of the lead?

If this is the way you use this feature, would it be ok to only show staff reviewers in the fold out section? And not all reviewers (that can be a long list indeed)?

@frjo frjo added the question label Mar 14, 2019
@fourthletter
Copy link
Contributor Author

fourthletter commented Mar 15, 2019

@frjo We are using the batch action to assign reviewers in the list view through the round or fund: https://apply.opentech.fund/apply/rounds/794/

The lead and other staff members are unable to see in this view which individuals have been assigned primary or secondary reviewers because this information is not visible: https://apply.opentech.fund/apply/rounds/794/

The lead and other staff members are able to see who has signed up as primary or secondary when they go to the submission directly. We are unable to use the batch action when this information is not visible in a central location.

@fourthletter
Copy link
Contributor Author

@frjo I am attaching the features discussed during testing and development phase: #1016

@frjo
Copy link
Contributor

frjo commented Mar 18, 2019

This is now on test ready for your testing. http://test-apply.opentech.fund/apply/submissions/

I made the "Review outcome" list staff reviewers even if they have not submitted an review so they are always visible, the outcome is then set to "—".

Does this seem like an acceptable solution?

@frjo frjo added the Status: Needs testing Tickets that need testing/qa label Mar 18, 2019
@frjo frjo self-assigned this Mar 18, 2019
@frjo
Copy link
Contributor

frjo commented Mar 19, 2019

@arduina Removed screen dumps since these issues are public and submission information should not be public (deleted revisions om the comments as well).

@arduina
Copy link

arduina commented Mar 19, 2019

Oh gosh, you're right. Thank you.

@frjo frjo removed the Status: Needs testing Tickets that need testing/qa label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants