Ignore updated_at and updated_by field values when updating plots via the API. #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The android app sends `updated_by`. It doesn't know it's a foreign key, neither does the api, so it gets set to the `id` rather than the model. This causes a `ValueError` in auditing. The api already has a list of attributes to ignore. `updated_by` can be safely ignored because it is set in auditing. Same for `updated_at`. Since they are supposed to be set in auditing, they really should both be ignored. So ignore them. -- Connects to OpenTreeMap/otm-android#303 Connects to OpenTreeMap/otm-android#304
|
It passed jenkins when mis-targeted at |
jwalgran
approved these changes
Jan 30, 2017
There was a problem hiding this comment.
I reproduced OpenTreeMap/otm-android#303 and OpenTreeMap/otm-android#304 and verified that this prevents them.
We do always want the server to be the authority on updated_by and updated_at.
|
I would like to change the title of this PR to the more descriptive summary "Ignore updated_at and updated_by field values when updating plots via the API." |
RobinIsTheBird
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The android app sends
updated_by. It doesn't know it's a foreign key,neither does the api, so it gets set to the
idrather than the model.This causes a
ValueErrorin auditing.The api already has a list of attributes to ignore.
updated_bycan be safely ignored because it is set in auditing.Same for
updated_at. Since they are supposed to be set in auditing,they really should both be ignored.
So ignore them.
--
Connects to OpenTreeMap/otm-android#303
Connects to OpenTreeMap/otm-android#304