Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add stewardship activities #304

Closed
dboyer opened this issue Jan 30, 2017 · 1 comment
Closed

Cannot add stewardship activities #304

dboyer opened this issue Jan 30, 2017 · 1 comment
Assignees
@RobinIsTheBird
Labels
+ bug high
Milestone
2.14.0

Comments

@dboyer
Copy link

dboyer commented Jan 30, 2017 •
edited by RobinIsTheBird
Loading

Tested on v47

  1. Set stewardship activities to "full write access" for public user role
  2. Access map with public user account
  3. Add tree with species and diameter
  4. Save tree successfully
  5. Click back into tree record
  6. Select edit
  7. Add stewardship activity
  8. Click save
  9. Receive "cannot save tree" message
@RobinIsTheBird RobinIsTheBird self-assigned this Jan 30, 2017
@RobinIsTheBird
Copy link
Contributor

RobinIsTheBird commented Jan 30, 2017 •
edited
Loading

Confirmed. Added to the Fix Immediate card.

@dboyer dboyer added this to the 2.14.0 milestone Jan 30, 2017
RobinIsTheBird added a commit to RobinIsTheBird/otm-core that referenced this issue Jan 30, 2017
@RobinIsTheBird
Fix api edit
3db9f77 
The android app sends `updated_by`. It doesn't know it's a foreign key,
neither does the api, so it gets set to the `id` rather than the model.
This causes a `ValueError` in auditing.

The api already has a list of attributes to ignore.
`updated_by` can be safely ignored because it is set in auditing.
Same for `updated_at`. Since they are supposed to be set in auditing,
they really should both be ignored.

So ignore them.

--

Connects to OpenTreeMap/otm-android#303
Connects to OpenTreeMap/otm-android#304
@RobinIsTheBird RobinIsTheBird mentioned this issue Jan 30, 2017
Closed
RobinIsTheBird added a commit to RobinIsTheBird/otm-core that referenced this issue Jan 30, 2017
@RobinIsTheBird
Fix api edit
78766cd 
The android app sends `updated_by`. It doesn't know it's a foreign key,
neither does the api, so it gets set to the `id` rather than the model.
This causes a `ValueError` in auditing.

The api already has a list of attributes to ignore.
`updated_by` can be safely ignored because it is set in auditing.
Same for `updated_at`. Since they are supposed to be set in auditing,
they really should both be ignored.

So ignore them.

--

Connects to OpenTreeMap/otm-android#303
Connects to OpenTreeMap/otm-android#304
@RobinIsTheBird RobinIsTheBird mentioned this issue Jan 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobinIsTheBird RobinIsTheBird

Labels
+ bug high
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
3 participants
@dboyer @RobinIsTheBird @RickMohr