Fix UDF choice editing helper function #3259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces use of `urllib` and `urllib2` with Requests library while attempting to maintain backwards compatibility.
…ests Upgrade Omgeo to v5.1.0
Adds a command to write out the feature id, tree id, and the URL of all photos for an instance as a CSV. This CSV can then be processed on a developer workstation to export all of the instance photos.
Add create_photo_csv management command
Tapping on the layers control in Mobile Safari was not opening the layer
selector. I was not able to reproduce this issue in a separate test application,
only within OTM.
After much trial and error I discovered that changing this line
L.DomEvent.on(el, L.Draggable.START.join(' '), stop);
to
L.DomEvent.on(container, 'mousedown', stop); in
DomEvent.disableClickPropagation resolved the issue. Effectively, this
prevents the `touchstart` event from being stopped.
I opted to implement this as a runtime patch applied within MapManager instead
of a global patch to the Leaflet source because there are no other Leaflet
behaviors that are known to be broken in Mobile Safari and I did not want to
risk introducing a regression in some other event handling.
I minimized the chance of forgetting about this patch if/when we upgrade our
version of Leaflet by adding a comment to package.json.
…ector Monkey patch the Leaflet layer selector to work in Mobile Safari
Removes the configuration file used by Circle CI.
Remove Circle CI support
Copied from https://docs.rollbar.com/docs/browser-js Attempts to remove the "Telemetry requires the latest release of rollbar.js." message when viewing logged errors on the Rollbar dashboard.
Addresses the following error raised by Chrome when viewing an embedded map:
SecurityError: Failed to read the 'localStorage' property from 'Window':
Access is denied for this document.
Update Rollbar JS client and catch localStorage security error
In the case where choice fields contain numeric values, this helper is called with a number and fails unless we force the value to a string.
mmcfarland
approved these changes
Nov 5, 2018
|
Thanks. I am going to retarget this to the newly created |
|
Dealing with an issue retargeting this to the hotfix branch. Will reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the case where choice fields contain numeric values, this helper is called with a number and fails unless we force the value to a string.
Connects https://github.com/OpenTreeMap/otm-clients/issues/441
Testing Instructions
developbranch+ Add FieldFinishto save it.
* Refresh the page and click `Edit`. Start typing a new choice value and you will see an exception in the console
* Checkout this branch, reload the page, and click `Edit`. * Verify that you can successfully add a new choice value and save it.