Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing/isolated taxa messages (phase 1) #404

Merged
merged 5 commits into from Aug 19, 2014
Merged

Conversation

jimallman
Copy link
Member

This includes the static/generic messages for missing and isolated taxa in the synthetic-tree viewer. See screenshots below for examples. Note that I've removed the awkward phrase "not a proper clade" and switched the messages (most likely explanations) shown for the missing vs. isolated taxon.

screen shot 2014-08-19 at 5 26 51 pm

screen shot 2014-08-19 at 5 27 07 pm

@kcranston
Copy link
Member

I think the messages might be reversed. The disconnected node happens when the taxa is in taxamachine but is not monophyletic in the synthetic tree.

@jimallman
Copy link
Member Author

OK, I've replaced the original messages for missing vs. orphaned taxa. The text for incertae sedis was a little different. Want new screenshots?

@kcranston
Copy link
Member

Here are my suggestions for the message text:

  • Case 1 (taxon not found / not in treemachine): This taxon is in our taxonomy but not in our tree synthesis database. This can happen for a variety of reasons, but the most probable is that it is flagged as incertae sedis. If you think this is an error, please add link for feedback / issues
  • Case 2 (unconnected taxa): This taxon exists in our taxonomy but is not connected to any other taxa in the synthetic tree. This happens when the taxon is non-monphyletic in contributed phylogenies. To contribute a phylogeny that supports monophyly of this taxon, use our link to curation application.

@jimallman
Copy link
Member Author

Updated screenshots with the revisions above:

screen shot 2014-08-19 at 6 33 55 pm

screen shot 2014-08-19 at 6 33 39 pm

@kcranston
Copy link
Member

Great! thanks!

kcranston added a commit that referenced this pull request Aug 19, 2014
Missing/isolated taxa messages (phase 1)
@kcranston kcranston merged commit cd48d80 into master Aug 19, 2014
@kcranston kcranston deleted the missing-taxon-phase-1 branch August 19, 2014 22:37
@jar398
Copy link
Member

jar398 commented Aug 20, 2014

Should be "taxon", not "taxa", where used as singular.

I don't like "is not connected" because in fact the taxon is connected to
taxa in the synthetic tree; just via links that are not displayed. I prefer
"is not in the synthetic tree" to "is not connected to any other taxa in
the synthetic tree" as it is simpler and more accurate. If you want
something a bit wordier, maybe "is excluded from the synthetic tree".

Should that maybe be "phylogenetic tree" instead of "phylogeny"?

Jonathan

On Tue, Aug 19, 2014 at 6:13 PM, Karen Cranston notifications@github.com
wrote:

Here are my suggestions for the message text:

  • Case 1 (taxa not found / not in treemachine): This taxa is in our
    taxonomy but not in our tree synthesis database. This can happen for a
    variety of reasons, but the most probable is that it is flagged as incertae
    sedis
    . If you think this is an error, please add link for feedback /
    issues
  • Case 2 (unconnected taxa): This taxa exists in our taxonomy but is
    not connected to any other taxa in the synthetic tree. This happens when
    the taxa is non-monphyletic in contributed phylogenies. To contribute a
    phylogeny that supports monophyly of this taxa, use our link to
    curation application
    .


Reply to this email directly or view it on GitHub
#404 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants