Improved tree properties #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also does a one-time capture of the deprecated ot:curatedType field before discarding it, as described in #555 (comment). Addresses #552, #555.
|
Awaiting review from KC and the MIAPA list |
|
@kcranston: The changes here to Nexson tree properties (incl. multiple inference method values, and a separate tree type) were the result of a lot of conversation, so I want to confirm that we're not planning to merge these changes. (As I noted elsewhere, these commits also crept into the 'support-tree-collections' branch, so I'll need to reverse them in that PR.) As a reminder, here's the current UI on production (before these changes): And here's the UI as modified by this PR: |
jimallman
added a commit
that referenced
this pull request
Sep 19, 2015
NOTE that we're keeping the inference-method UI changes from the support-tree-collections branch. These have not been formally accepted for merging, but I need them intact to attempt a git revert of this PR: #598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reflect our latest thinking in tree properties, as discussed in #552 and #555. Available now for review on devtree.
This also does a one-time capture of the deprecated
ot:curatedTypefield before discarding it, as described in #555 (comment). (This will have no effect if this migration has already been done on the server, which is probably the wiser path.)