This repository has been archived by the owner on Sep 22, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add '@label' property to 'matched_trees' (in singlePropertySearchForTrees response) #42
Labels
Comments
4 tasks
jimallman
changed the title
Add 'label' property to 'matched_trees' (in singlePropertySearchForTrees response)
Add '@label' property to 'matched_trees' (in singlePropertySearchForTrees response)
Jul 25, 2015
If I'm reading the oti code that builds matched_trees results correctly, the problem is that the On closer reading, I'm expecting to find this defined as |
For an example of a tree that definitely has a @Label, see It's called 'Placeholder tree', as we can see in phylesystem-0. But this label does not appear in its verbose oti result: $ curl -X POST 'http://devapi.opentreeoflife.org/oti/v1/singlePropertySearchForTrees' \
-H 'Content-Type: application/json; charset=UTF-8' \
--data-binary '{"property":"oti_tree_id","value":"tt_23_tree1","exact":true,"verbose":true}'
{
"matched_studies" : [ {
"ot:studyPublicationReference" : "Allman, Jim. Study to create a placeholder tree for the Tree Illustrator application, 1999.",
"ot:curatorName" : "Jim Allman",
"ot:studyId" : "tt_23",
"matched_trees" : [ {
"ot:studyId" : "tt_23",
"ot:nodeLabelMode" : "",
"ot:ottId" : 5260612,
"is_deprecated" : false,
"ot:branchLengthMode" : "ot:undefined",
"ot:originalLabel" : "D",
"oti_tree_id" : "tt_23_tree1",
"ot:ottTaxonName" : "D6",
"ot:branchLengthDescription" : ""
} ],
"ot:studyYear" : 1999,
"is_deprecated" : false,
"ot:focalCladeOTTTaxonName" : "",
"ot:dataDeposit" : "http://www.example.com/",
"ot:studyPublication" : "asdf",
"ot:comment" : "This is just to provide a simple placeholder tree for the Tree Illustrator."
} ]
} |
jimallman
added a commit
to OpenTreeOfLife/opentree
that referenced
this issue
Sep 27, 2015
This gives a nicer default, e.g., 'Tree tree801 from Davis, 2010'. N.B. that [this is *all* we're going to see until oti starts returning proper '@Label' properties for matched trees](OpenTreeOfLife/oti#42).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The user-edited tree name is stored in the
@label
property in Nexson. We need this in the response tosinglePropertySearchForTrees
, esp. for using oti to build tree collections.The text was updated successfully, but these errors were encountered: