Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexson export @rel, string booleans, ot:ottTaxonName #103

Open
mtholder opened this issue Mar 24, 2014 · 10 comments
Open

nexson export @rel, string booleans, ot:ottTaxonName #103

mtholder opened this issue Mar 24, 2014 · 10 comments

Comments

@mtholder
Copy link
Member

This should be 3 issues; I think there may be issues for some/all of these. Sorry I did not want this to fall through the cracks, and I was afraid that I'd forget...

  1. I think that meta tags of type "@xsi:type": "nex:ResourceMeta" should be using "@rel" rather than "$" for their content.
  2. I think we decided to use true rather than "true" for booleans. I'm seeing "true" for ot:isLeaf and the '@root' property.
  3. We decided that ot:ottTaxonName should be in otu objects not node objects.
@mtholder
Copy link
Member Author

FWIW, I'm using the workaround_phylografter_export_diffs function in https://github.com/OpenTreeOfLife/peyotl/blob/master/peyotl/nexson_validation/phylografter_workaround.py when importing (on my private testing repos).

@pmidford
Copy link
Contributor

Mark, I can deal with these tomorrow, or are you planning to do these today?
-Peter

On Monday, March 24, 2014, Mark T. Holder notifications@github.com wrote:

FWIW, I'm using the workaround_phylografter_export_diffs function in
https://github.com/OpenTreeOfLife/peyotl/blob/master/peyotl/nexson_validation/phylografter_workaround.pywhen importing (on my private testing repos).

Reply to this email directly or view it on GitHubhttps://github.com//issues/103#issuecomment-38439642
.

@mtholder
Copy link
Member Author

Hi. Tomorrow is fine. There is no real rush. My workaround script means that these issues are not holding me up.

@pmidford
Copy link
Contributor

Mark - Item 1 says use "@rel" rather than $, but I only find "@href" for specifying the value of these tags. No problem changing @href to @rel, but am I missing something here?

@mtholder
Copy link
Member Author

Sorry. I meant @rel instead of @Property for those meta elements that use
@href.
sorry for the confusion.

mark

On Thu, Mar 27, 2014 at 5:46 PM, Peter Midford notifications@github.comwrote:

Mark - Item 1 says use "@rel https://github.com/rel" rather than $, but
I only find "@href https://github.com/href" for specifying the value of
these tags. No problem changing @href https://github.com/href to @relhttps://github.com/rel,
but am I missing something here?


Reply to this email directly or view it on GitHubhttps://github.com//issues/103#issuecomment-38870522
.

Mark Holder

mtholder@gmail.com
mtholder@ku.edu
http://phylo.bio.ku.edu/mark-holder

Department of Ecology and Evolutionary Biology
University of Kansas
6031 Haworth Hall
1200 Sunnyside Avenue
Lawrence, Kansas 66045

lab phone: 785.864.5789

fax (shared): 785.864.5860

@mtholder
Copy link
Member Author

@pmidford
Copy link
Contributor

pmidford commented Apr 3, 2014

Should be fixed - @mtholder could you verify this is what you want.

@rhr
Copy link
Member

rhr commented Apr 3, 2014

Won't be live until I restart the app, which I'm waiting on as there's
quite a bit of user activity at the moment.

On Thu, Apr 3, 2014 at 3:23 PM, Peter Midford notifications@github.comwrote:

Should be fixed - @mtholder https://github.com/mtholder could you
verify this is what you want.

Reply to this email directly or view it on GitHubhttps://github.com//issues/103#issuecomment-39500148
.

@rhr
Copy link
Member

rhr commented Apr 3, 2014

Restarted - now live

On Thu, Apr 3, 2014 at 3:43 PM, Richard Ree rree@fieldmuseum.org wrote:

Won't be live until I restart the app, which I'm waiting on as there's
quite a bit of user activity at the moment.

On Thu, Apr 3, 2014 at 3:23 PM, Peter Midford notifications@github.comwrote:

Should be fixed - @mtholder https://github.com/mtholder could you
verify this is what you want.

Reply to this email directly or view it on GitHubhttps://github.com//issues/103#issuecomment-39500148
.

@josephwb
Copy link
Member

josephwb commented Apr 4, 2014

We on the treemachine side were not keeping up with this, so treemachine cannot currently read these nexsons. I am working on updating NexsonReader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants